70 %

Toast is in Beta!Learn more →

Chris Biscardi

Things that make your PR hard to merge

Unrelated changes

Including changes that are unrelated to the change being PR'd.

examples

  • You've written some additional documentation... and also formatted many of the files in the repo.
  • You've included a refactor along with a functional change.

Multiple changes

  • You've implemented feature A and also documented feature B... but the docs for feature B have problems that prevent the merge of the PR
  • You've implemented feature A and feature B, resulting in it being hard to differentiate which code is supposed to have what effect.

Merge commits

Sometimes maintainers will have to carry your PR (to carry is to take your PR and make additional changes before merging). Merge commits make it harder to work with your commit history.

Not scoping before PRing

Large, unannounced changes are unlikely to be merged unless architectural discussions have happened beforehand.